Promote Pod Disruption Budgets to GA #27053

mortent · 2021-03-14T21:34:38Z

PR to update documentation after PDBs have been promoted to GA.

KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/85-Graduate-PDB-to-Stable/README.md
Issue: kubernetes/enhancements#85
PR: kubernetes/kubernetes#99290

k8sio-netlify-preview-bot · 2021-03-14T21:34:42Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit d341b96

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60629404e39e8500089e4089

reylejano · 2021-03-15T03:42:57Z

/assign
/sig apps

reylejano · 2021-03-15T03:43:45Z

/remove-language es ja ko zh

sftim

Hi @mortent. Would you be willing to just change the English localization (en) here? SIG Docs localization teams pick up these changes independently from one another and each team can pick its own different process for managing their backlog.
We'll need this PR to omit changes to other localizations before we can merge it.
/hold

You might also want to check about including the changes for issue #26385 in this update. It's also OK if those come in as 2 PRs.

Optional extra tidying

add min-kubernetes-server-version: 1.21 to the front matter of content/en/docs/tasks/run-application/configure-pdb.md
and add {{< version-check >}} into the prerequisites section
- this is because older clusters don't have a PDB API available as policy/v1
remove “(available in Kubernetes 1.7 and higher)” as v1.7 is a long time out of support

content/en/docs/concepts/workloads/pods/disruptions.md

content/en/docs/tasks/run-application/configure-pdb.md

mortent · 2021-03-18T21:53:44Z

@sftim I have removed the changes to any other languages than English and updated the PR based on your suggestions.

reylejano · 2021-03-22T15:29:12Z

Hi @mortent , thank you for having your Doc PR ready for review, here are upcoming doc related dates for the 1.21 release:
Upcoming doc related dates for the 1.21 release:

~~Docs Ready for Review deadline is March 24~~
Docs Ready to Merge deadline is March 31

reylejano · 2021-03-22T15:29:44Z

@kubernetes/sig-apps-pr-reviews , please provide a technical review for this PR by March 31 to get this into the release. Thank you!

sftim · 2021-03-23T22:31:17Z

content/en/docs/tasks/run-application/configure-pdb.md

+PodDisruptionBudgets. For policy/v1beta1 an empty selector matches zero pods, while
+for policy/v1 an empty selector matches every pod in the namespace.
+{{< /note >}}
+
 {{< note >}}


Consider omitting the “For versions 1.8 and earlier” note as v1.8 is long out of support.

Removed the section.

Earlier feedback was addressed

content/en/docs/concepts/workloads/pods/disruptions.md

sftim · 2021-03-26T01:36:00Z

content/en/docs/tasks/run-application/configure-pdb.md

@@ -17,6 +18,8 @@ nodes.

 ## {{% heading "prerequisites" %}}

+{{< version-check >}}


I recommend (not essential, but a good idea) that we ask people using older Kubernetes versions to check the documentation for that Kubernetes version.

Not sure I understand what we are looking for here. Is there an example I can look at?

kow3ns · 2021-03-30T03:27:11Z

/approve

kow3ns · 2021-03-30T03:27:18Z

/lgtm

k8s-ci-robot · 2021-03-30T03:27:31Z

LGTM label has been added.

Git tree hash: 0c55f99f6adf201fd077b9f4924d227d67e181f9

tengqm · 2021-03-30T03:57:59Z

/approve

k8s-ci-robot · 2021-03-30T03:58:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kow3ns, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

reylejano · 2021-03-30T15:30:21Z

/hold cancel

k8s-ci-robot added this to the 1.21 milestone Mar 14, 2021

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2021

k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 14, 2021

k8s-ci-robot requested review from electrocucaracha and kakts March 14, 2021 21:34

mortent force-pushed the PDBsToGA21 branch from 8649864 to 4e84c26 Compare March 14, 2021 22:07

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2021

mortent marked this pull request as ready for review March 14, 2021 22:16

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2021

k8s-ci-robot assigned reylejano Mar 15, 2021

k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Mar 15, 2021

k8s-ci-robot removed language/es Issues or PRs related to Spanish language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language labels Mar 15, 2021

sftim mentioned this pull request Mar 16, 2021

Mention PDB updates in PodDisruptionBudget task page #26385

Closed

sftim previously requested changes Mar 16, 2021

View reviewed changes

content/en/docs/concepts/workloads/pods/disruptions.md Outdated Show resolved Hide resolved

content/en/docs/tasks/run-application/configure-pdb.md Outdated Show resolved Hide resolved

content/en/docs/tasks/run-application/configure-pdb.md Outdated Show resolved Hide resolved

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2021

mortent force-pushed the PDBsToGA21 branch from 4e84c26 to 3ced683 Compare March 18, 2021 21:51

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2021

sftim reviewed Mar 23, 2021

View reviewed changes

mortent force-pushed the PDBsToGA21 branch from 3ced683 to 5fc9c10 Compare March 23, 2021 22:44

annajung reviewed Mar 26, 2021

View reviewed changes

content/en/docs/concepts/workloads/pods/disruptions.md Show resolved Hide resolved

sftim reviewed Mar 26, 2021

View reviewed changes

mortent force-pushed the PDBsToGA21 branch from 5fc9c10 to dbc5f78 Compare March 30, 2021 02:56

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2021

Promote Pod Disruption Budgets to GA

d341b96

mortent force-pushed the PDBsToGA21 branch from dbc5f78 to d341b96 Compare March 30, 2021 02:59

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2021

k8s-ci-robot assigned kow3ns Mar 30, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021

k8s-ci-robot merged commit 0d2a4c7 into kubernetes:dev-1.21 Mar 30, 2021

liggitt mentioned this pull request Apr 29, 2021

PodDisruptionBudget and /eviction subresource kubernetes/enhancements#85

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote Pod Disruption Budgets to GA #27053

Promote Pod Disruption Budgets to GA #27053

mortent commented Mar 14, 2021

k8sio-netlify-preview-bot commented Mar 14, 2021 •

edited

Loading

reylejano commented Mar 15, 2021

reylejano commented Mar 15, 2021

sftim left a comment

mortent commented Mar 18, 2021

reylejano commented Mar 22, 2021

reylejano commented Mar 22, 2021

sftim Mar 23, 2021

mortent Mar 23, 2021

sftim Mar 26, 2021

mortent Mar 30, 2021

kow3ns commented Mar 30, 2021

kow3ns commented Mar 30, 2021

k8s-ci-robot commented Mar 30, 2021

tengqm commented Mar 30, 2021

k8s-ci-robot commented Mar 30, 2021

reylejano commented Mar 30, 2021

		@@ -17,6 +18,8 @@ nodes.

		## {{% heading "prerequisites" %}}

		{{< version-check >}}

Promote Pod Disruption Budgets to GA #27053

Promote Pod Disruption Budgets to GA #27053

Conversation

mortent commented Mar 14, 2021

k8sio-netlify-preview-bot commented Mar 14, 2021 • edited Loading

reylejano commented Mar 15, 2021

reylejano commented Mar 15, 2021

sftim left a comment

Choose a reason for hiding this comment

mortent commented Mar 18, 2021

reylejano commented Mar 22, 2021

reylejano commented Mar 22, 2021

sftim Mar 23, 2021

Choose a reason for hiding this comment

mortent Mar 23, 2021

Choose a reason for hiding this comment

sftim Mar 26, 2021

Choose a reason for hiding this comment

mortent Mar 30, 2021

Choose a reason for hiding this comment

kow3ns commented Mar 30, 2021

kow3ns commented Mar 30, 2021

k8s-ci-robot commented Mar 30, 2021

tengqm commented Mar 30, 2021

k8s-ci-robot commented Mar 30, 2021

reylejano commented Mar 30, 2021

k8sio-netlify-preview-bot commented Mar 14, 2021 •

edited

Loading